Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr-pull-datapoints should filter status based on category and includeGuessedCategories flag #386

Conversation

MadDataScience
Copy link
Contributor

Related Issues

  • closes T-42535 tr-pull-datapoints should filter status based on category and includeGuessedCategories flag

Security Implications

[none]

System Availability

[none]

Copy link

height bot commented Feb 18, 2025

This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:

  • T-42535 tr-pull-datapoints should filter status based on category and includeGuessedCategories flag (unlink task)

💡Tip: You can link multiple Height tasks to a pull request.

@MadDataScience
Copy link
Contributor Author

Having a little trouble testing this. When I try running

yarn tr-pull-datapoints --auth=$TRANSCEND_API_KEY --file=./datapoints.csv --transcendUrl=https://api.staging.transcen.dental --parentCategories=DEMOGRAPHIC,ID,FINANCIAL,LOCATION,CONNECTION,NOT_PERSONAL_DATA

I get

Source path: /workspaces/cli/build/cli-pull-datapoints.js
Not found: /workspaces/cli/build/cli-pull-datapoints.js

I suspect I've got a problem with my build, but I haven't been able to fix it.

@anotherminh
Copy link
Member

@MadDataScience for dev you need:

yarn ts-node ./src/cli-pull-datapoints.ts --auth=$TRANSCEND_API_KEY

package.json Outdated
@@ -2,7 +2,7 @@
"author": "Transcend Inc.",
"name": "@transcend-io/cli",
"description": "Small package containing useful typescript utilities.",
"version": "6.14.3",
"version": "6.14.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should this be 6.15.0? @anotherminh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What other comment? I see the one about how to run it (which worked, by the way) but not about whether this would be a minor or a dot change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anotherminh did you have a comment about version? (Realized you might not have seen my last message since I forgot to tag)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hmmm sorry i was confused about this question! My b!

I think minor sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor it is. Thanks!

@MadDataScience MadDataScience requested a review from a team February 18, 2025 20:50
@MadDataScience MadDataScience merged commit 29e467d into main Feb 18, 2025
10 checks passed
@MadDataScience MadDataScience deleted the maddatascience/T-42535-tr-pull-datapoints-should-filter-status-based-on-category-and-includegue branch February 18, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants